Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query cleanup: Avoid static parameters #16167

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Query cleanup: Avoid static parameters #16167

merged 1 commit into from
Jun 21, 2019

Conversation

smitpatel
Copy link
Contributor

No description provided.

@AndriySvyryd
Copy link
Member

What's wrong with static parameters?

@smitpatel
Copy link
Contributor Author

Passing them in the visitors which need them rather than making them public seemed conservative for now.

@smitpatel smitpatel merged commit ab1c1f4 into master Jun 21, 2019
@ghost ghost deleted the smit/cleanup2 branch June 21, 2019 18:12
@ajcvickers ajcvickers mentioned this pull request Jun 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@maumar maumar Awaiting requested review from maumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smitpatel @AndriySvyryd